[PULL] MAXSCREENS removal preparation

Vignatti Tiago (Nokia-D/Helsinki) tiago.vignatti at nokia.com
Mon Apr 26 09:32:39 PDT 2010


On Mon, Apr 26, 2010 at 05:48:54PM +0200, ext Keith Packard wrote:
> 
> One thing I'm working on in parallel is to fix the devPrivates
> implementation in the server so that adding a bunch of screen privates
> won't impact memory usage. Right now, every screen private we add
> increases the size of every pixmap, window, gc, colormap and cursor by 8
> bytes (on a 32-bit system).
> 
> I've got a patch for that almost ready, which is independent of your
> changes but which should be included in the 1.9 release with your
> changes. I think you'll like them in any case; we'll shrink all of these
> data structures by a significant amount.

sweet. 

One thing I find pretty bad with devPrivates logic is the readability of the
code. To debug it's even worst because we inherited from somewhere this crazy
idea to use macros in mostly dixLookupPrivate calls.

I don't think there're some apparent issues that don't let us to organize
better this all over the server. For instance, just use inline functions
instead macros would help a lot when debugging.

                            Tiago


More information about the xorg-devel mailing list