[PATCH] Accumulate graphics exposures incrementally in PanoramiXCopyArea.

[Keith Packard]

On Fri, 23 Apr 2010 19:52:56 -0700, Jamey Sharp <jamey at minilop.net> wrote:
> This fuses two loops, eliminating an intermediate MAXSCREENS-sized
> array.
> 
> Aside from being more efficient, I believe this is equivalent to the
> previous implementation, assuming that
> - each per-screen GC has the graphicsExposures flag set the same way,
>   and

The Xinerama GC ops keep them in sync; check out XineremaCreateGC and friends.

> - the REGION_* macros continue to ignore their screen argument.

Unlikely to ever change now.

I've reviewed this as best I can, but I'd like to see someone actually
give it a try.

Reviewed-by: Keith Packard <keithp at keithp.com>

> 
> Signed-off-by: Jamey Sharp <jamey at minilop.net>
> ---
> 
> What's up with the REGION_* macros anyway? AFAICT they've never cared
> about their screen argument for as long as we have history in git.

The region functions used to be per-screen.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100423/af1e37a7/attachment.pgp>