[PATCH] xfree86: fix not reached code in tty code

Peter Hutterer peter.hutterer at who-t.net
Wed Apr 21 14:40:36 PDT 2010


On Wed, Apr 21, 2010 at 06:43:34PM +0300, Vignatti Tiago (Nokia-D/Helsinki) wrote:
> On Wed, Apr 21, 2010 at 12:19:07AM +0200, ext Peter Hutterer wrote:
> > 
> > stack the reviewed patches into a for-keith branch, push them to your $HOME
> > on people.freedesktop.org and then send Keith a pull request.
> > 
> > what I usually do is 
> > 'git request-pull master git://people.freedesktop.org/~whot/xserver.git for-keith > pull-req'
> > and then 'mutt -H pull-req'
> > 
> > note that this requires master to be something close-ish to upstream, if
> > you've diverged in other ways just insert the last sha1 instead of "master".
> > in my case, master is usually origin/master from where I started
> > development, so origin/master may have moved on since.
> > 
> > given that you already have the patches in a tree, it's faster to do this
> > than to wait for Keith to apply and push them, he has pull requests on
> > precedence AFAICT.
> 
> very useful information, Peter. Thanks.
> 
> I was thinking maybe to drop this in our wiki. Do you think there's a better
> place than here:
> 
> http://wiki.x.org/wiki/Development/Documentation/SubmittingPatches

http://www.x.org/wiki/XServer
describes the server process and the above is already on there. Though it
would be good to have a link from the SubmittingPatches website, feel free
to add it there in the appropriate place.
(and add what is missing to the XServer page)

Cheers,
  Peter


More information about the xorg-devel mailing list