[PATCH v3 3/4] xfree86/dri2: wrap drm bits with macros and change drm_magic type

Mikhail Gusarov dottedmag at dottedmag.net
Wed Apr 21 10:57:09 PDT 2010


Twas brillig at 11:40:37 21.04.2010 UTC+03 when
ext-pauli.nieminen at nokia.com did gyre and gimble:

 PN> diff --git a/hw/xfree86/dri2/dri2ext.c b/hw/xfree86/dri2/dri2ext.c
 PN> index 17df130..e8fd749 100644
 PN> --- a/hw/xfree86/dri2/dri2ext.c
 PN> +++ b/hw/xfree86/dri2/dri2ext.c
 PN> @@ -42,7 +42,9 @@
 PN>  #include "scrnintstr.h"
 PN>  #include "pixmapstr.h"
 PN>  #include "extnsionst.h"
 PN> +#ifdef WITH_LIBDRM
 PN>  #include "xf86drm.h"
 PN> +#endif
 PN>  #include "xfixes.h"
 PN>  #include "dri2.h"
 PN>  #include "protocol-versions.h"

Actually I did not check it, but this hunk looks suspicious - why do you
need to conditionally include header in .c when there are no #ifdefs
below?

-- 
  http://fossarchy.blogspot.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100422/d7bbe48c/attachment.pgp>


More information about the xorg-devel mailing list