[PATCH v3 3/4] xfree86/dri2: wrap drm bits with macros and change drm_magic type

[Matt Turner]

On Wed, Apr 21, 2010 at 9:00 AM, Mark Kettenis <mark.kettenis at xs4all.nl> wrote:
>> Date: Wed, 21 Apr 2010 15:34:48 +0300
>> From: Tiago Vignatti <tiago.vignatti at nokia.com>
>>
>> On Wed, Apr 21, 2010 at 11:53:04AM +0200, ext Mark Kettenis wrote:
>> >
>> > I'll reiterate an opinion stated here before.  We should really try to
>> > *reduce* the number of #ifdefs in the code base, not introduce new
>> > ones.
>>
>> In general you're right. We prefer clear code without these ugly #ifdefs all
>> around. But this is not always the case and, I agree, a good justification is
>> needed to introduce them.
>>
>> In our case, we don't want to employ libdrm in the device because it's simply
>> not used. I don't care about the space that this library uses there, but I
>> care about the maintenance that I'd have to do. And that counts a lot.
>
> So instead you decide to increase the maintenance burden on everybody
> else by making the code harder to read and requiring them to remember
> to wrap new code that depends on libdrm in more #ifdefs.

Are you doing this for other people's benefit? I can only find one
commit from you to the xserver (06c0372c3a1b45005) and it was more
than two years ago. I didn't search very hard though.

Matt