[PATCH input-acecad] config: optional extension check for inputproto not required

Peter Hutterer peter.hutterer at who-t.net
Sun Apr 18 16:52:20 PDT 2010


On Fri, Apr 16, 2010 at 03:17:44PM -0400, Gaetan Nadon wrote:
> The check should be in PKG_CHECK_MODULES permanently.
> 
> The XORG_DRIVER_CHECK_EXT will add inputproto to PKG_CHECK_MODULES
> only if the extension is available. By definition, this extension
> is always available and the acecad driver cannot function without it.
> 
> This is evidenced by the absence of XINPUT conditional code.
> 
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
>  configure.ac |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 19d3c66..1121e29 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -54,11 +54,8 @@ AC_CHECK_LIB([sysfs], [sysfs_close_bus])
>  # Checks for header files.
>  AC_CHECK_HEADERS([linux/input.h sysfs/libsysfs.h])
>  
> -# Store the list of server defined extensions in REQUIRED_MODULES
> -XORG_DRIVER_CHECK_EXT(XINPUT, inputproto)
> -
>  # Obtain compiler/linker options from server and required extensions
> -PKG_CHECK_MODULES(XORG, [xorg-server >= 1.0.99.901] xproto $REQUIRED_MODULES)
> +PKG_CHECK_MODULES(XORG, [xorg-server >= 1.0.99.901] xproto inputproto)
>  
>  # Define a configure option for an alternate input module directory
>  AC_ARG_WITH(xorg-module-dir,
> -- 
> 1.6.0.4

Acked-by: Peter Hutterer <peter.hutterer at who-t.net>

Cheers,
  Peter


More information about the xorg-devel mailing list