xdm: Changes to 'master'

Jeremy Huddleston jeremyhu at apple.com
Wed Apr 14 14:54:52 PDT 2010


I wish I caught the AC_CONFIG_MACRO_DIR([m4]) change before xdm-1.1.10 shipped.  I *really* dislike it because it leads to build failures with libtool.  Yes, the ac_define_dir.m4 is good to have in there rather than acinclude.m4, but 'make dist' also packages up a bunch of libtool cruft which can cause build failures.

If the builder runs 'autoreconf -fvi' from the tarball, the packager's libtool m4 macros will be used, and the builder's libtool will be used!

I just hit this with the new xdm tarball on Leopard which shipped libtool-1.5.22 ... sure, I can 'rm -rf m4/l{ib,}t*' first, but that should not be needed.

--Jeremy


On Mar 15, 2010, at 23:35, Alan Coopersmith wrote:

> .gitignore          |    5 +++++
> Makefile.am         |    1 +
> acinclude.m4        |   45 ---------------------------------------------
> auth.c              |    4 ++--
> configure.ac        |    1 +
> m4/ac_define_dir.m4 |   45 +++++++++++++++++++++++++++++++++++++++++++++
> 6 files changed, 54 insertions(+), 47 deletions(-)
> 
> New commits:
> commit c9cdd56df50f280e90ba95cfa933222f94ad2677
> Author: Alan Coopersmith <alan.coopersmith at sun.com>
> Date:   Mon Mar 15 23:34:04 2010 -0700
> 
>    Move m4 macros to m4 subdir as automake/libtool recommend
> 
>    Signed-off-by: Alan Coopersmith <alan.coopersmith at sun.com>
> 
> commit b9226288b96f0c5988d2c2f52718674d39803a5e
> Author: Alan Coopersmith <alan.coopersmith at sun.com>
> Date:   Mon Mar 15 23:21:30 2010 -0700
> 
>    Replace hardcoded NAMELEN of 14 for ancient SysV with MAXNAMELEN
> 
>    Signed-off-by: Alan Coopersmith <alan.coopersmith at sun.com>
> 
> _______________________________________________
> xorg-commit mailing list
> xorg-commit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xorg-commit



More information about the xorg-devel mailing list