[PATCHv2 2/2] glx: Drop DestroyWindow hook

Michel Dänzer michel at daenzer.net
Wed Apr 14 08:19:04 PDT 2010


On Wed, 2010-04-14 at 10:43 -0400, Kristian Høgsberg wrote: 
> 2010/4/10 Michel Dänzer <michel at daenzer.net>:
> > On Fri, 2010-04-09 at 14:18 -0400, Kristian Høgsberg wrote:
> >> Now that glx doesn't call DRI2DestroyDrawable anymore, we don't need to
> >> force a specific resource destruction order in the DestroyWindow hook.
> >
> > I don't think DRI2DestroyDrawable was the only reason for this, see e.g.
> > commit 2075d4bf9e53b8baef0b919da6c44771220cd4a5 ('glx: If a destroyed
> > window is bound to the current context, make it not current.') and the
> > bug report referenced by it.
> 
> There's no bug report reference in that commit [...]

Look again. :) It references
https://bugs.freedesktop.org/show_bug.cgi?id=21132#c15 , according to
which the commit fixes the crash shown in
https://bugs.freedesktop.org/attachment.cgi?id=25038 , which doesn't
have anything to do with DRI2 but with stale DrawablePtrs due to the
window being destroyed while it's still bound to a GLX context.


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the xorg-devel mailing list