[PATCH macros] linuxdoc: Use XORG_WITH_PS2PDF to check for ps2pdf

Gaetan Nadon memsize at videotron.ca
Tue Apr 13 15:17:23 PDT 2010


On Tue, 2010-04-13 at 12:55 -0500, Yaakov (Cygwin/X) wrote:

> From: Yaakov Selkowitz <yselkowitz at users.sourceforge.net>
> 
> Besides reusing existing code, this allows linuxdoc PDF output to be
> enabled or disabled by configure.
> 
> Signed-off-by: Yaakov Selkowitz <yselkowitz at users.sourceforge.net>
> ---
>  xorg-macros.m4.in |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
> index 916b472..412ee66 100644
> --- a/xorg-macros.m4.in
> +++ b/xorg-macros.m4.in
> @@ -213,9 +213,9 @@ AC_SUBST(XORG_SGML_PATH)
>  # with the AM_CONDITIONAL "BUILD_LINUXDOC"
>  AC_DEFUN([XORG_CHECK_LINUXDOC],[
>  AC_REQUIRE([XORG_CHECK_SGML_DOCTOOLS])
> +AC_REQUIRE([XORG_WITH_PS2PDF])
>  
>  AC_PATH_PROG(LINUXDOC, linuxdoc)
> -AC_PATH_PROG(PS2PDF, ps2pdf)
>  
>  AC_MSG_CHECKING([whether to build documentation])
>  
> @@ -231,7 +231,7 @@ AC_MSG_RESULT([$BUILDDOC])
>  
>  AC_MSG_CHECKING([whether to build pdf documentation])
>  
> -if test x$PS2PDF != x && test x$BUILD_PDFDOC != xno; then
> +if test x$have_ps2pdf != xno && test x$BUILD_PDFDOC != xno; then
>     BUILDPDFDOC=yes
>  else
>     BUILDPDFDOC=no


Reviewed-by: Gaetan Nadon <memsize at videotron.ca>

It's not because of your patch, but can you check where BUILD_PDFDOC
might be set?
It would be too complicated if there were too many switches for the same
function.





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100413/fa32c94a/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100413/fa32c94a/attachment.pgp>


More information about the xorg-devel mailing list