[PATCH xinit] Simplify environment juggling by using fork() instead of vfork()

Alan Coopersmith alan.coopersmith at oracle.com
Tue Apr 13 08:46:49 PDT 2010


Mikhail Gusarov wrote:
> Twas brillig at 08:31:41 13.04.2010 UTC-07 when alan.coopersmith at oracle.com did gyre and gimble:
>  AC> A couple formatting issues I note:
> 
>  AC> git am warned of a trailing whitespace issue when applying:
>  AC>   .dotest/patch:106: trailing whitespace.
>  AC>                 snprintf(newwindowpath, len, "%s:%s",
> 
> There's still lot of trailing whitespace in file. I tried to avoid
> touching it.

Yes, but git picked this one up because you edited that line anyway.

> Is it okay to rework it into patch series, starting with [PATCH 1/x]
> "reindent this stuff"?

Yes - if you apply a new consistent formatting style, doing that as the
first patch of a series seems fine to me.   There used to be a recommended
set of flags to the indent program somewhere in the xserver docs, but I
think we may have dropped that file at some point.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list