[PATCH libX11 3/4] man: Fix value of XkbAllComponentsMask in XkbGetKeyboard

[Dirk Wallenstein]

On Wed, Feb 03, 2010 at 10:51:36AM -0800, Jeremy Huddleston wrote:
> 
> On Feb 3, 2010, at 10:12, Dirk Wallenstein wrote:
> 
> >On Tue, 02 Feb 2010 13:44:48 -0800 Jeremy Huddleston wrote:
> >>I'd prefer to see this written as:
> >>
> >>(1L<<7) - 1L
> >
> >If it's a value I'd like to have it in sync with the code for easy
> >comparison. I can change both if you like. Alternatively I could
> >use the
> >OR-ed other masks.
> 
> 
> I think (next - 1) is less prone to human error when adding bits in
> the future.  That's my main concern.
> 
> I think OR-ing all the others does not scale well and also suffers
> from the same human-error aspect.
> 
> Consistency is great.  Add the change to the header as well, I think
> that's a good idea.
> 
> Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
> 

I tried in another thread but there are type divergence issues that
would have to be solved additionally in a questionable separate effort.

Are you ok with the patch as is?