[PATCH] mi: remove log-spamming bogus error message (#26843)
Thomas Jaeger
thjaeger at gmail.com
Wed Apr 7 15:43:41 PDT 2010
Thanks. How about the other error messages of this form? I'm also
hitting miSpriteSetCursor in bug #26843; I don't know how useful the
error message is for the remaining functions (miSpriteRestoreCursor etc.).
Thanks,
Tom
On 04/06/2010 11:24 PM, Peter Hutterer wrote:
> miSpriteRealizeCursor is called whenever a device is set floating and it's
> fine to do so, no need for an error message.
>
> X.Org Bug 26843 <http://bugs.freedesktop.org/show_bug.cgi?id=26843>
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> mi/misprite.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/mi/misprite.c b/mi/misprite.c
> index 2ec6782..8e56cd3 100644
> --- a/mi/misprite.c
> +++ b/mi/misprite.c
> @@ -765,10 +765,8 @@ miSpriteRealizeCursor (DeviceIntPtr pDev, ScreenPtr pScreen, CursorPtr pCursor)
>
> pScreenPriv = dixLookupPrivate(&pScreen->devPrivates, miSpriteScreenKey);
> if (!IsMaster(pDev) && !pDev->u.master)
> - {
> - ErrorF("[mi] miSpriteRealizeCursor called for floating device.\n");
> return FALSE;
> - }
> +
> pCursorInfo = MISPRITE(pDev);
>
> if (pCursor == pCursorInfo->pCursor)
> -- 1.6.6.1
More information about the xorg-devel
mailing list