[RFC PATCH] Initial libudev input-hotplug support

[Julien Cristau]

On Wed, Sep 30, 2009 at 08:47:27 +0200, Rémi Cardona wrote:

> Hi Julien,
> 
> Le mardi 29 septembre 2009 à 23:54 +0200, Julien Cristau a écrit :
> > If libudev is found, we use that for hotplug and disable the hal and
> > dbus backends.
> 
> Why disable dbus? I see udev being in conflict with HAL, but not with
> the dbus code.

Yeah, I could do that.

> Not that it matters much, I don't think any tool/utility
> uses the dbus interfaces anyway. Maybe it's time to ditch it?
> 
[...]
> > +
> > +#define UDEV_PROP_KEY "x11_options."
> > +#define UDEV_XKB_PROP_KEY "xkb."
> 
> <harmless bikeshedding>
> Why not merge the 2 into a single :
> 
> UDEV_PROP_KEY "xorg."
> </bikeshedding>
> 
> I think the "xkb" HAL keys were deprecated in favor of
> "x11_options.Xkb*", let's at least drop the deprecated one.
> 
Well my understanding was that input.xkb.foo was preferred.  There's
nothing strictly x11-specific to the xkb keys (we use the
xkeyboard-config data files to set the console keymap, e.g.).

[...]
> > +AC_ARG_ENABLE(config-udev,    AS_HELP_STRING([--enable-config-udev], [Build udev support (default: auto)]), [CONFIG_UDEV=$enableval], [CONFIG_UDEV=auto])
> >  AC_ARG_ENABLE(config-dbus,    AS_HELP_STRING([--enable-config-dbus], [Build D-BUS API support (default: no)]), [CONFIG_DBUS_API=$enableval], [CONFIG_DBUS_API=no])
> >  AC_ARG_ENABLE(config-hal,     AS_HELP_STRING([--disable-config-hal], [Build HAL support (default: auto)]), [CONFIG_HAL=$enableval], [CONFIG_HAL=auto])
> >  AC_ARG_ENABLE(xfree86-utils,     AS_HELP_STRING([--enable-xfree86-utils], [Build xfree86 DDX utilities (default: enabled)]), [XF86UTILS=$enableval], [XF86UTILS=yes])
> > @@ -742,6 +743,25 @@ LIBXI="xi >= 1.2.99.1"
> >  LIBPCIACCESS="pciaccess >= 0.8.0"
> >  LIBGLIB="glib-2.0 >= 2.16"
> 
> Maybe we could have --enable-config={dbus,hal,udev,none} instead?
> 
> Anyhow, I don't have much else to say about the real libudev code except
> that it's well indented ;)
> 
Thanks,
Julien