[PATCH] Add XF86TouchpadToggle to XKeysymDB

Peter Hutterer peter.hutterer at who-t.net
Fri Sep 25 18:51:03 PDT 2009


On Fri, Sep 25, 2009 at 01:11:11PM -0400, James Cloos wrote:
> >>>>> "Peter" == Peter Hutterer <peter.hutterer at who-t.net> writes:
> 
> Peter> Many laptops provide a key to enable or disable the touchpad and the
> Peter> trackstick. On Lenovo T61s, this key is located on Fn + F8.
> 
> Peter> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> 
> Peter> +XF86TouchpadToggle	:1008FFA9
> 
> If that is added, then proto/x11proto/XF86keysym.h also needs to #define
> that symbol.

Right, will do so, thanks for reminding.

> Some time back the suggestion was made that we (Xorg) shouldn't be
> adding to the XF86 symbols, but rather should be adding symbols in
> our own range.  (It may have been long enough ago to predate this
> list; one might also need to check the xorg@ archives if one were
> to try to find it.)
> 
> It would be the first non-vendor keysym of that sort, though. So
> where to place it is a good question, if a non-vendor keysym is
> the chosen route.

I wonder what we do gain by not adding XF86 symbols anymore and adding them
to a different namespace. Many of the XF86 symbols are already in use and
the namespace is at least well known. There's no hiding that Xorg is based
on Xfree86 either.

To me, all these XF86 prefixes are similar to the Apple APIs that still have
a NS prefix. It's there, we know what it stands for but it doesn't really
matter.

Is there a technical reason to create a new namespace?
(after checking the available range we're not running out of symbols just
yet)

Cheers,
  Peter


More information about the xorg-devel mailing list