[PATCH] configure: fix REQUIRED_MODULES, it was not being set at all

Peter Hutterer peter.hutterer at who-t.net
Sun Sep 20 04:08:32 PDT 2009


On Fri, Sep 18, 2009 at 11:16:22AM -0700, Alan Coopersmith wrote:
> Dan Nicholson wrote:
> >> -REQUIRED_MODULES="randrproto >= 1.2.99.3 "    \
> >> -                 "renderproto >= 0.11 "       \
> >> -                 "damageproto >= 1.1 "        \
> > 
> > I don't see why the original was a problem, but can you leave the line
> > continuation markers in there? Having variables with newlines in them
> > is not fun.
> 
> Adjacent strings concatenate in C, but every shell I'm aware of treats
> them as separate words, so that would set REQUIRED_MODULES to the first
> quoted string, use the second quoted string as the command to run, and
> the rest of the quoted strings as arguments to that command.

sigh. i just tested again and yes, you're right. the error was hidden
between the general configure noise that I didn't spot it and configure
didn't fail because of it. sorry about that.
 
Cheers,
  Peter


More information about the xorg-devel mailing list