[PATCH] configure.ac: move all protocol requirements to a single location.

Jeremy Huddleston jeremyhu at apple.com
Tue Sep 15 10:50:07 PDT 2009


On Sep 15, 2009, at 02:20, Peter Hutterer wrote:

>>> +FIXESPROTO="[fixesproto >= 4.0]"
>>> +
>>> dnl Core modules for most extensions, et al.
>>> -REQUIRED_MODULES="[randrproto >= 1.2.99.3] [renderproto >= 0.11]  
>>> [fixesproto >= 4.0] [damageproto >= 1.1] [xcmiscproto >= 1.2.0]  
>>> [xextproto >= 7.0.99.3] [xproto >= 7.0.13] [xtrans >= 1.2.2]  
>>> [bigreqsproto >= 1.1.0] resourceproto fontsproto [inputproto >=  
>>> 1.9.99.902] [kbproto >= 1.0.3]"
>>> +REQUIRED_MODULES="[randrproto >= 1.2.99.3] "    \
>>> +                 "[renderproto >= 0.11] "       \
>>> +                 "[damageproto >= 1.1] "        \
>>> +                 "[xcmiscproto >= 1.2.0] "      \
>>> +                 "[xextproto >= 7.0.99.3] "     \
>>> +                 "[xproto >= 7.0.13] "          \
>>> +                 "[xtrans >= 1.2.2] "           \
>>> +                 "[bigreqsproto >= 1.1.0] "     \
>>> +                 "resourceproto "               \
>>> +                 "fontsproto "                  \
>>> +                 "[inputproto >= 1.9.99.902] "  \
>>> +                 "[kbproto >= 1.0.3] "          \
>>> +                 "$FIXESPROTO "
>>
>> if fixesproto is not optional, why list it above rather than here?
>
> fixesproto is the only one that is separately listed (for Darwin,  
> around
> line 1723). In hindsight, that seems superfluous since  
> REQUIRED_MODULES is
> always checked for. Jeremy, any comments?

This was added for pbproxy (a PRIMARY/CLIPBOARD <-> NSPateboard  
synchronization utility) which is currently a client-app running as a  
separate thread on the server or another process (depending on ./ 
configure options).

The only fixes header that it explicitly needs is the Xlib one  
(extensions/XFixes.h) which is provided by xfixes.

I believe we can drop the $FIXESPROTO from the REQURED_ list.  The  
explicit fixesproto was just redundantly placed in the darwin hunk of  
configure.ac

--Jeremy



More information about the xorg-devel mailing list