[PATCH] xfree86: vgaarb: make arbiter optional at build time (v2)

Peter Hutterer peter.hutterer at who-t.net
Sun Sep 13 23:42:08 PDT 2009


On Fri, Sep 11, 2009 at 07:04:25PM +0300, Tiago Vignatti wrote:
> This patch implements the option of a server without support for vga
> arbitration, using dummy functions. It introduces --{enable, disable}-vgaarb
> to autoconf (enabled by default).
> 
> Note that the server now requires libpciaccess >= 0.10.8.
> 
> Signed-off-by: Tiago Vignatti <tiago.vignatti at nokia.com>
> ---
> 
> What about this one, Dave? I don't know if this way is how you thought. Well,
> here are the stats:
> 
> - with vgaarbiter
>    text    data     bss     dec     hex filename
> 1658395   48164   43756 1750315  1ab52b /opt/master/bin/Xorg
> 
> - without vgaarbiter and with dummy functions we got .7411 % of text removal:
>    text    data     bss     dec     hex filename
> 1646105   48008   43756 1737869  1a848d /opt/master/bin/Xorg
> 
> - without vgaarbiter with ugly macros (previous patch) all over the code we 
>   got .7657 % of text removal:
>    text    data     bss     dec     hex filename
> 1645698   47976   43756 1737430  1a82d6 /opt/master/bin/Xorg
> 
> So it's far from being an extraordinary removal but IMHO already justifies.

Judging from the irc conversation following this patch it looks like we need
an option to disable the whole bus, not just the arbiter.
Since you yourself mentioned this is ongoing, I'd rather you wait and merge
it when it applies to everything to avoid having a zillion options.

Cheers,
  Peter


More information about the xorg-devel mailing list