[PATCH:app/xdm] Replace -D_XOPEN_SOURCE & -D_BSD_SOURCE with AC_USE_SYSTEM_EXTENSIONS

Alan Coopersmith alan.coopersmith at sun.com
Fri Sep 11 11:11:10 PDT 2009


Signed-off-by: Alan Coopersmith <alan.coopersmith at sun.com>
---
 Since this mostly affects Linux systems, I'd appreciate those with more
 experience there confirming this is the right idea.  
 
 AC_USE_SYSTEM_EXTENSIONS defines _GNU_SOURCE, which seems to include
 both _BSD_SOURCE & _XOPEN_SOURCE if I read features.h correctly, but
 may have other side effects.    xdm seems to build fine with this patch
 on Fedora 11, but I haven't tested it extensively.

 configure.ac |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index 655eae6..b0b4fea 100644
--- a/configure.ac
+++ b/configure.ac
@@ -21,7 +21,7 @@ dnl
 dnl Process this file with autoconf to create configure.
 
 
-AC_PREREQ([2.57])
+AC_PREREQ([2.60])
 AC_INIT(xdm,[1.1.8],[https://bugs.freedesktop.org/enter_bug.cgi?product=xorg],xdm)
 AM_INIT_AUTOMAKE([dist-bzip2])
 AM_MAINTAINER_MODE
@@ -32,6 +32,7 @@ XORG_MACROS_VERSION(1.3)
 
 AM_CONFIG_HEADER(config.h)
 
+AC_USE_SYSTEM_EXTENSIONS
 AC_PROG_CC
 AM_PROG_CC_C_O
 AC_C_INLINE
@@ -135,7 +136,7 @@ fi
 
 case $host_os in
     linux*|gnu*|*-gnu)
-        OS_CFLAGS="-D_XOPEN_SOURCE -D_BSD_SOURCE"
+        OS_CFLAGS=""
 	SU="su"
         ;;
     darwin*)
@@ -454,7 +455,7 @@ AC_SUBST(XDMSHELL_LIBS)
 # Chooser
 #
 
-CHOOSER_CFLAGS="-D_BSD_SOURCE $CHOOSER_CFLAGS $XDM_PRINT_CFLAGS $XLIB_CFLAGS $DMCP_CFLAGS $AUTH_CFLAGS"
+CHOOSER_CFLAGS="$CHOOSER_CFLAGS $XDM_PRINT_CFLAGS $XLIB_CFLAGS $DMCP_CFLAGS $AUTH_CFLAGS"
 CHOOSER_LIBS="$CHOOSER_LIBS $XDM_PRINT_LIBS $DMCP_LIBS"
 
 AC_SUBST(CHOOSER_CFLAGS)
-- 
1.5.6.5



More information about the xorg-devel mailing list