[PATCH] Supply all code using dl*() with DLOPEN_LIBS

Dan Nicholson dbn.lists at gmail.com
Thu Oct 29 11:08:53 PDT 2009


On Thu, Oct 29, 2009 at 6:16 AM, Mikhail Gusarov
<dottedmag at dottedmag.net> wrote:
>
> Twas brillig at 06:06:10 29.10.2009 UTC-07 when dbn.lists at gmail.com did gyre and gimble:
>
>  >> +libglxdri_la_LIBADD = @DLOPEN_LIBS@
>
>  DN> Is there a reason not to just use the variable $(DLOPEN_LIBS)?
>
> Use where?
>
> Do you just mean s/@DLOPEN_LIBS@/$(DLOPEN_LIBS)/g ?

Yes. The current patch will result in:

Makefile:
DLOPEN_LIBS = -ldl
...
libglxdri_la_LIBADD = -ldl

Since the variable is already in the Makefile, it would be nicer to use it.

Makefile:
DLOPEN_LIBS = -ldl
...
libglxdri_la_LIBADD = $(DLOPEN_LIBS)

It's both clearer what's going and allows flexibility (in corner
cases) for zero cost.

--
Dan


More information about the xorg-devel mailing list