[PATCH] EXA: fix mixed-pixmaps issue where we could do accel with pixmap mapped

[Ben Skeggs]

On Tue, 2009-10-27 at 19:00 +0900, Michel Dänzer wrote:
> On Mon, 2009-10-26 at 19:22 +0100, Maarten Maathuis wrote: 
> > On Mon, Oct 26, 2009 at 6:53 PM, Keith Packard <keithp at keithp.com> wrote:
> > > Excerpts from skeggsb's message of Fri Oct 23 17:45:49 -0700 2009:
> > >
> > >> -    if (pExaPixmap->pDamage && exaPixmapIsOffscreen(pPixmap)) {
> > >> +    if (pExaPixmap->pDamage && exaPixmapIsOffscreen(pPixmap) &&
> > >> +    !pExaPixmap->offscreen) {
> > >
> > > This doesn't apply on master which has two cases inside the condition.
> > >
> > 
> > Both situations involve pixmap copying, something which is not
> > desirable if prepare access succeeded.
> 
> True, however master might need more changes due to the deferred upload
> mechanism added there, e.g. in exaDoMigration_mixed(). I'm afraid I
> don't have time right now to think this through properly.
Yeah, I've thought of that already, it's on the list to look at once
more pressing issues have been dealt with.

> 
> Anyway, Ben's change should be good as is for server-1.7-branch, and any
> further changes for master won't apply there anyway, so maybe it can be
> fast-tracked to server-1.7-nominations.
Agreed, definitely should make it into 1.7.

Ben.
> 
>