[PATCH:app/xlsclients] Use inttypes.h for correct printf formats

Jeremy Huddleston jeremyhu at freedesktop.org
Tue Oct 20 20:13:54 PDT 2009


This is C99, right?  If so, I don't think it's acceptable.

On Oct 20, 2009, at 18:56, Yaakov (Cygwin/X) wrote:

> From: Yaakov Selkowitz <yselkowitz at users.sourceforge.net>
>
> xcb_atom_t and xcb_window_t are both typedef'd as uint32_t.
>
> Signed-off-by: Yaakov Selkowitz <yselkowitz at users.sourceforge.net>
> ---
> xlsclients.c |    5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/xlsclients.c b/xlsclients.c
> index 2452352..24f36f5 100644
> --- a/xlsclients.c
> +++ b/xlsclients.c
> @@ -34,6 +34,7 @@ in this Software without prior written  
> authorization from The Open Group.
> #include <stdlib.h>
> #include <string.h>
> #include <ctype.h>
> +#include <inttypes.h>
> #include <xcb/xcb.h>
> #include <xcb/xproto.h>
> #include <xcb/xcb_atom.h>
> @@ -442,7 +443,7 @@ show_client_properties(void *closure)
>      * do header information
>      */
>     if (cs->verbose) {
> -	printf ("Window 0x%lx:\n", cs->w);
> +	printf ("Window 0x%" PRIx32 ":\n", cs->w);
> 	print_text_field (cs->c, "  Machine:  ", client_machine);
> 	if (name && name->type)
> 	    print_text_field (cs->c, "  Name:  ", name);
> @@ -645,5 +646,5 @@ unknown(xcb_connection_t *dpy, xcb_atom_t  
> actual_type, int actual_format)
> 	} else
> 	    fputs (Nil, stdout);
>     }
> -    printf (" (%ld) or format %d>", actual_type, actual_format);
> +    printf (" (%" PRIu32 ") or format %d>", actual_type,  
> actual_format);
> }
> -- 
> 1.6.4.2
>
> _______________________________________________
> xorg-devel mailing list
> xorg-devel at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5820 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091020/029c321e/attachment.bin 


More information about the xorg-devel mailing list