xlsclients: Changes to 'master'

[Yaakov (Cygwin/X)]

On 19/10/2009 20:41, Jamey Sharp wrote:
> commit 1839eabbdd697039a264fe7ebb3f4d26f08ddabe
> Author: Peter Harris<pharris at opentext.com>
> Date:   Mon Oct 19 18:21:26 2009 -0700
>
>      Rewrite xlsclients to use XCB, avoiding many (many) round trips

This is generating several warnings:

   CC     xlsclients.o
xlsclients.c: In function 'show_client_properties':
xlsclients.c:445: warning: format '%lx' expects type 'long unsigned 
int', but argument 2 has type 'xcb_window_t'
xlsclients.c:445: warning: format '%lx' expects type 'long unsigned 
int', but argument 2 has type 'xcb_window_t'
xlsclients.c: In function 'print_quoted_word':
xlsclients.c:587: warning: array subscript has type 'char'
xlsclients.c: In function 'show_client_properties':
xlsclients.c:422: warning: 'wm_class' may be used uninitialized in this 
function
xlsclients.c:421: warning: 'icon_name' may be used uninitialized in this 
function
xlsclients.c:420: warning: 'name' may be used uninitialized in this function
xlsclients.c: In function 'unknown':
xlsclients.c:648: warning: format '%ld' expects type 'long int', but 
argument 2 has type 'xcb_atom_t'
xlsclients.c:648: warning: format '%ld' expects type 'long int', but 
argument 2 has type 'xcb_atom_t'

Both xcb_atom_t and xcb_window_t are typedef'd as uint32_t in 
<xcb/xproto.h>.  A (unsigned) long int isn't necessary the same as a 
(u)int32_t, particularly on 64-bit machines.  Perhaps <inttypes.h> and 
PRIu32 are in order here?


Yaakov
Cygwin/X