[PATCH] Define FD_SETSIZE on Cygwin regardless of XWin DDX

Yaakov (Cygwin/X) yselkowitz at users.sourceforge.net
Mon Oct 19 13:06:00 PDT 2009


On 19/10/2009 14:47, Jon TURNEY wrote:
> This could have a better comment, perhaps:
>
> "FD_SETSIZE must be at least XFD_SETSIZE for uses of select() to be correct.
> The Cygwin default is only 64, so it must be increased to 256"
>
> It looks like this could potentially affect anything which includes Xpoll.h,
> so we need to audit uses of Select() outside the server for the same problem.

Or maybe, in Xpoll.h we could do something like this:

  #define XFD_SETSIZE 256

-#ifndef FD_SETSIZE
+#if !defined(FD_SETSIZE) || FD_SETSIZE < XFD_SETSIZE
+#undef FD_SETSIZE
  #define FD_SETSIZE  XFD_SETSIZE
  #endif

Thoughts?


Yaakov
Cygwin/X


More information about the xorg-devel mailing list