luit: Cygwin compatibility

Adam Jackson ajax at nwnk.net
Tue Oct 6 08:21:13 PDT 2009


On Mon, 2009-10-05 at 19:08 -0500, Yaakov (Cygwin/X) wrote:

> Cygwin has O_NOCTTY but no TIOCSCTTY, so the tty is never made 
> controlling.  This raises two questions:
> 
> 1) What is the point of O_NOCTTY if TIOCSCTTY is called right afterwards?

Hah!  Can't think of one.

> 2) If there is a good reason for that, we could patch it:
> 
> +#ifdef __CYGWIN__
> +    tty = open(line, O_RDWR);
> +#else
>       tty = open(line, O_RDWR | O_NOCTTY);
> +#endif

That should be fine.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
Url : http://lists.x.org/archives/xorg-devel/attachments/20091006/fd29e7e7/attachment.pgp 


More information about the xorg-devel mailing list