[PATCH v2] Add libgcrypt as an option for sha1

[Daniel Stone]

On Sun, Oct 04, 2009 at 01:51:38PM +0200, Julien Cristau wrote:
> Add --with-sha1={libmd,libgcrypt,libcrypto} configure option to select
> between the different implementations.
> 
> Signed-off-by: Julien Cristau <jcristau at debian.org>
> ---
> On Sun, Oct  4, 2009 at 11:53:49 +1100, Daniel Stone wrote:
> 
> > On Thu, Sep 24, 2009 at 01:41:31PM +0200, Julien Cristau wrote:
> > > Signed-off-by: Julien Cristau <jcristau at debian.org>
> > > ---
> > > We've been using that in Debian since April (to avoid openssl's
> > > gpl-incompatible license, and because gcrypt is already in our base
> > > system).  One thing I'm not sure about is in what order to check for
> > > things in configure, or whether we need something like
> > > --with-sha1={libmd,libcrypto,libgcrypt}.
> > 
> > Hi,
> > --with-sha1={libmd,libgcrypt,libcrypto} sounds ideal.
> > 
> How about this one then?

Looks good to me.  If you break it all out into separate utility
functions in os/ or dix/ (e.g. [0] or similar) and document the result
at least in the header file you add it to, I'll even test it. :)

Cheers,
Daniel

[0]:
#ifdef USE_OPENSSL
void do_openssl_sha1(char sha1sum[20]) { ... }
#endif
void calculate_sha1(char sha1sum[20]) {
#ifdef USE_OPENSSL
	do_openssl_sha1(sha1sum);
#else ...
#endif
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091004/0cd17514/attachment.pgp