[PATCH] Use PRId32/PRIx32 from inttypes.h for printf of CARD32 values.

Matthieu Herrb matthieu.herrb at laas.fr
Sat Oct 3 22:54:45 PDT 2009


Daniel Stone wrote:
> On Fri, Oct 02, 2009 at 01:42:46PM -0700, Jamey Sharp wrote:
>> Signed-off-by: Jamey Sharp <jamey at minilop.net>
>> ---
>>  hw/xfree86/int10/helper_exec.c |   28 ++++++++++++++--------------
>>  1 files changed, 14 insertions(+), 14 deletions(-)
>>
>> diff --git a/hw/xfree86/int10/helper_exec.c b/hw/xfree86/int10/helper_exec.c
>> index 6ba647f..38b0adf 100644
>> --- a/hw/xfree86/int10/helper_exec.c
>> +++ b/hw/xfree86/int10/helper_exec.c
>> @@ -219,7 +219,7 @@ port_rep_inb(xf86Int10InfoPtr pInt,
>>      register int inc = d_f ? -1 : 1;
>>      CARD32 dst = base;
>>      if (PRINT_PORT && DEBUG_IO_TRACE())
>> -	ErrorF(" rep_insb(%#x) %ld bytes at %8.8lx %s\n",
>> +	ErrorF(" rep_insb(%#x) %" PRId32 " bytes at %8.8" PRIx32 " %s\n",
>>  		port, count, base, d_f ? "up" : "down");
>>      while (count--) {
>>  	MEM_WB(pInt, dst, x_inb(port));
> 
> Is this portable beyond glibc? Alan? Matthieu?

No. Ith's C99 and some systems (OpenBSD at least) don't have those C99
features yet.

We'll have to provide alternatives for now.
-- 
Matthieu Herrb


More information about the xorg-devel mailing list