checked sources of xorg-server 1.7.0 with static code analysis tool cppcheck
dickey at his.com
Sat Oct 3 06:11:35 PDT 2009
On Sat, 3 Oct 2009, Michel Dänzer wrote:
> On Sat, 2009-10-03 at 08:43 -0400, Thomas Dickey wrote:
>> On Sat, 3 Oct 2009, Michel Dnzer wrote:
>>> What purpose is that? If these functions were actually called with a
>>> NULL PixmapPtr, surely the current code would have crashed with a
>>> segmentation fault.
>> I suppose that if you prefer the server to crash rather than check error
>> conditions, there's no point in the change.
> I'd expect ModifyPixmapHeader getting called with a NULL PixmapPtr to
> always be a bug in the caller. I'd rather catch and fix that than cover
> it up. Maybe I'm missing something.
The called function is one point to check,
the calling functions are potentially many.
Duplicating checks around random points is something that we attempt to
train people not to do.
Thomas E. Dickey
More information about the xorg-devel