unwrapping inside the wrapper (xf86Rotate)

[Keith Packard]

Excerpts from Dave Airlie's message of Wed Sep 30 17:20:28 -0700 2009:

> I just thought about this some more, if you have dynamic block handler
> removal outside the block handler, won't the dynamically added/removed
> handler always happen last i.e. after the driver one?

No, the dynamically added handler will always happen first in this
case -- it'll be placed directly in the ScreenRec.

My only question is what happens at server startup time; it would be
necesary to know precisely when the rotation handler would get
inserted into the ScreenRec and whether any other code was initialized
after that.

> I really don't think you've thought this fully out, so I'll send a
> patch to fix xf86Rotate.c to not dynamically block handle, and
> if you want for 1.8 we can audit and fix up properly including all the
> drivers.

I'm good with this plan; I have to admit that the whole wrapper notion
is altogether too fragile as it trusts too much to correct programming
which cannot be tested easily.

> Sound sane?

Yes.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091001/d53ffb86/attachment.pgp