[PATCH 3/3] exa: properly wrap Create/DestroyPixmap in ExaCheckPolyArc and fix GC (un)wrapping.

Michel Dänzer michel at daenzer.net
Thu Nov 12 10:29:24 PST 2009


On Sat, 2009-11-07 at 13:32 +0100, Maarten Maathuis wrote: 
> - Fix the system that is required for it to actually work.
> - The comment near the new macros explains the problem that existed before.

I'm not sure it really explains why we need two levels of wrapping.

> - Why it didn't cause issues before i don't know.
> - We cannot unwrap the GC funcs, because they do prepare/finish access too.
> - Protect against setting CreatePixmap twice (which would break swapping) in GC
>   functions.

Would it be feasible to make a general - not specific to PolyArc -
solution, in case other fb hooks use / start using temporary pixmaps?


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the xorg-devel mailing list