xf86UDelay was used - removal breaks drivers

Mark Kettenis mark.kettenis at xs4all.nl
Fri Nov 6 15:51:40 PST 2009


> Date: Fri, 06 Nov 2009 15:31:27 -0800
> From: Alan Coopersmith <Alan.Coopersmith at Sun.COM>
> 
> This commit:
> 
>    commit 9522ab9a98e98bc394703038e34b1c12aa39a179
>    Author: Matt Turner <mattst88 at gmail.com>
>    Date:   Mon Aug 31 16:12:29 2009 -0400
> 
>     Remove unused Delay.c
> 
> has broken a number of drivers that used the previously exported
> xf86UDelay function, including:
> 	xf86-video-ast
> 	xf86-video-chips
> 	xf86-video-glint
> 	xf86-video-neomagic
> 	xf86-video-rendition
> 
> Are updates going to be issued to all these drivers to use a different
  > function, or should the removal be reverted?

I really don't understand the removal of functions like that.  Even if
xf86UDelay() has simply become the same as usleep(), there is no
reason to break the ABI over it.  It's not as if it's a big
maintenance burden to keep the function around.

I think you should just revert the commit. 


More information about the xorg-devel mailing list