[PATCH] [alpha] Remove unused code, _dense_* functions, iobase stuff

Mark Kettenis mark.kettenis at xs4all.nl
Sun Nov 1 13:26:11 PST 2009


> Date: Sun, 1 Nov 2009 16:15:47 -0500
> From: Matt Turner <mattst88 at gmail.com>
>
> On Sun, Nov 1, 2009 at 4:04 PM, Mark Kettenis <mark.kettenis at xs4all.nl> wrote:
> >> From: Matt Turner <mattst88 at gmail.com>
> >> Date: Sun,  1 Nov 2009 15:05:08 -0500
> >>
> >> This code has been unused since the switch to libpciaccess. It
> >> really should have been killed by fba700f1f6a8976.
> >
> > Uh, what makes you think so?  As far as I can tell, libpciaccess only
> > handles mmio.  One could argue that libpciaccess should also handle
> > "legacy" io, but until that is implemented, and the drivers have been
> > adjusted, I think at least some of this code is still necessary.
> 
> The only user of _alpha_iobase_query (defined lnx_axp.c:171) was
> hw/xfree86/os-support/bus/axpPci.c, through _iobase (defined
> lnx_axp.c:136).
> 
> >From there, the call heirarchy is
> _alpha_iobase_query
> |
> |--- _alpha_iobase_legacy
> |
> |--- _alpha_iobase
> |
> |--- _alpha_{out,in}{b,w,l}
>        |
>        |--- _dense_{out,in}{b,w,l}
> 
> I don't have any hardware capable of testing sparse support, but it's
> either already broken (so killing this code won't hurt anything) or
> it's working (so killing this unused code won't hurt anything).
> 
> So...

Ah well, if you're not implying that this is now handled by
libpciaccess, and if dense support on Linux still works after this
change, this should be fine.



More information about the xorg-devel mailing list