[PATCH 3/5] syndaemon: if we wanted XRECORD, but it failed, exit.

Julien Cristau jcristau at debian.org
Mon Mar 2 01:27:27 PST 2009


On Mon, Mar  2, 2009 at 12:46:38 +1000, Peter Hutterer wrote:

> If Xrecord is missing but we requested it (say, didn't disable it explicitly),
> then exit. Don't use the alternative SHM area, it's bad for your health.
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>  tools/syndaemon.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/syndaemon.c b/tools/syndaemon.c
> index 64a26da..066baae 100644
> --- a/tools/syndaemon.c
> +++ b/tools/syndaemon.c
> @@ -535,8 +535,13 @@ main(int argc, char *argv[])
>  	}
>      }
>  #ifdef HAVE_XRECORD
> -    if (use_xrecord && check_xrecord(display)) {
> -	record_main_loop(display, idle_time);
> +    if (use_xrecord)
> +    {
> +	if(check_xrecord(display))
> +	    record_main_loop(display, idle_time);
> +	else
> +	    fprintf(stderr, "Use of XRecord requested, but failed to "
> +		    " initialize.\n");

Probably want to exit non-zero here?

>      } else
>  #endif /* HAVE_XRECORD */
>        {

Cheers,
Julien


More information about the xorg-devel mailing list