X server testing

[Thomas Jaeger]

Peter Hutterer wrote:
>> * The super modifier (Mod4Mask) isn't reported any longer in state field
>> of core events and passive grabs containing this modifier in their
>> modifier mask don't work anymore.
> 
> not sure about that yet, I blame daniel ;)
> This could actually be a long-standing bug, there's a bug about syndaemon
> ignoring Mod4 which is potentially the same.

Sorry about this, it turns out updating xkeyboard-config to latest git
fixes the issue.

>> * Subpixel coordinates are not working for me.  Glancing through the
>> code, I think this is to be expected for devices like my tablet whose
>> device resolution is higher than the screen resolution, but it seems
>> that this should work for accelerated devices like my trackpoint.  Once
>> again, not really a big deal.
> 
> yes, those bits are missing. sorry. subpixels right now are only for accel
> code. feel free to send me a patch for this though, rescaleValuatorAxis
> should be it.

I've attached a series of patches enabling subpixel coordinates for
high-resolution devices along with a few minor refactorings and a
bugfix.  I haven't noticed any additional issues running this code for
the last few days.

I don't like how the pointer acceleration code currently handles
subpixel coordinates:  I think it'd be much cleaner if it didn't modify
pDev->last.remainder[...] directly, but instead returned the new
subpixel value, for example using the following interface.  I'd be happy
to supply a patch.

/* pointer acceleration handling */
typedef void (*PointerAccelSchemeProc)(
    DeviceIntPtr /*pDev*/,
    int /*first_valuator*/,
    int /*num_valuators*/,
    int* /*valuators*/,
    float* /*x_frac*/,
    float* /*y_frac*/,
    int /*evtime*/
);

Thanks,
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dix-deal-with-first_valuator-0-correctly-if-POINTER_.patch
Type: text/x-patch
Size: 0 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20090622/a78d58f8/attachment.bin