Should events.h be installed as part of the SDK?
Aaron Plattner
aplattner at nvidia.com
Thu Jul 23 15:42:09 PDT 2009
In include/Makefile.am, events.h and eventconvert.h were included in
nodist_sdk_HEADERS, which meant that they were installed to
$prefix/include/xorg but not included in the distribution tarball,
breaking dist builds. It seems like the intention was exactly the
opposite, but events.h is used by input.h (which in turn is included by
xf86str.h), so just dropping it from the SDK would break drivers. For
now, I just put it in SDK_HEADERS.
On IRC, you mentioned that all input.h needs from events.h is the
InternalEvent union. However, it looks like input.h just uses
InternalEvent*. You could probably get away with a
typedef union _InternalEvent InternalEvent;
in input.h and then name the union _InternalEvent in events.h.
-- Aaron
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
More information about the xorg-devel
mailing list