[PATCH] exa: Split out some classic and driver allocated pixmap code into seperate files

Maarten Maathuis madman2003 at gmail.com
Wed Jul 22 14:45:31 PDT 2009


2009/7/22 Michel Dänzer <michel at daenzer.net>:
> On Wed, 2009-07-22 at 21:42 +0200, Maarten Maathuis wrote:
>> - Rename exa_migration.c to exa_migration_classic.c
>> - Create a few seperate functions and a few private function pointers.
>> - Replace a few if conditions with a check for pExaPix->pDamage instead.
>> - This is in preperation of a third scheme that lies somewhere in between.
>
> Some things like the file rename

There will be a 2nd "migration" file, hence the rename.

> or the move of struct _ExaMigrationRec

I needed the definition earlier, and it was easier than doing an extra typedef.

> seem gratuitous, but otherwise it looks okay. However, I don't have a
> very good idea yet where you're going with the third scheme, might be
> easier to review this patch together with that.

I wanted to argue the interface changes first. In short it will be a
migration scheme on top of driver pixmaps. This is because things like
trapezoids should be done on system ram. The only major difference to
"end users" will be that this will also handle the frontbuffer
"migration". I'm expecting to perform better than a wfb based driver

>
>
> --
> Earthling Michel Dänzer           |                http://www.vmware.com
> Libre software enthusiast         |          Debian, X and DRI developer
>


More information about the xorg-devel mailing list