[PATCH] xserver: Unclaim PCI slot if driver probing fails.

[Tiago Vignatti]

On Wed, Jul 01, 2009 at 03:38:41PM +0200, ext Matthias Hopf wrote:
> At SUSE we try to use fbdev if possible, so if we cannot use a native
> driver we want to use the fbdev driver, and fail back to vesa if fbdev
> fails (e.g. if the mode on the kernel parameter line failed to set).
> 
> This doesn't work with the current xserver, after the first driver has
> been probed, the pci slot remains claimed. Apparently this was never
> thought to be an issue, because functions for unclaiming pci slots are
> missing.
> 
> This patch unclaims a pci slot by setting its bus type to BUS_NONE, so
> it doesn't match any more. I don't remove the allocation slot at the
> moment, because I'm unsure that there are no references left (and this
> is unlikely to be a regularly called function).
> 
> This fixes Novell bug #511529.
> 
> Thoughts?

Sounds a good temporally approach. On the other hand, ideally we should not
stack anything else in that ridiculous device initialization code there. It's
getting worse with the time.


Cheers,

            Tiago