[PATCH] A few build.sh features

[Nicolai Hähnle]

Am Dienstag 17 Februar 2009 15:25:44 schrieb Dan Nicholson:
> On Mon, Feb 16, 2009 at 11:15 AM, Ian Romanick <idr at freedesktop.org> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Brian Rogers wrote:
> >> Here are a few patches that do things I found useful.
> >>
> >>
> >> 1. Specify -p to run 'git pull' on each component before building it.
> >
> > NAK.  You really want 'git fetch ; git rebase origin/<current branch>'.
> >  git-pull really is the wrong thing to do here!  I have a separate
> > script that does this for everything in the tree.  The function that
> > does the fetch / rebase is:
>
> I don't know what version of git this showed up in, but you can just
> run "git pull --rebase" so it runs rebase instead of merge. So, you
> could probably just use that.
>
> On the other hand, I suspect that most people using build.sh are
> people that are just trying to keep up with xorg git and don't have
> patches that they're trying to keep on top of master. In that case, a
> simple pull would probably be fine for build.sh. I think anyone
> developing X probably has their own build setup not using build.sh.

Please never, ever use this kind of logic. The people who want to start with 
developing X have just as little clue about the intricacies of the build 
system as the people who are only trying to track xorg git. So they will look 
in the same places for tools to help with their needs.

In a very real way, it is *more* important for those helper scripts to work 
well for people who are actually doing the development, because having good 
development tools helps attracts developers.

And if the tools work well for developers, they very likely will work well for 
people who are only tracking, too.

By the way, I work on Mesa (and occasionally fiddle with the corresponding 
DDX), and I use this build.sh, or rather a very hacked up version of it, 
tailored to my needs. But I started out with a helper script that I just 
downloaded off the internets.

cu,
Nicolai