[PATCH 1/4] Coverity: dix/resource.c: leaked_storage: Variable "funcs" goes out of scope

Keith Packard keithp at keithp.com
Mon Dec 28 22:23:39 PST 2009


On Mon, 28 Dec 2009 12:02:55 +0200, Oliver McFadden <oliver.mcfadden at nokia.com> wrote:
> 
> Signed-off-by: Oliver McFadden <oliver.mcfadden at nokia.com>
> ---
>  dix/resource.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/dix/resource.c b/dix/resource.c
> index 91d0cfb..71774d1 100644
> --- a/dix/resource.c
> +++ b/dix/resource.c
> @@ -209,7 +209,10 @@ CreateNewResourceType(DeleteType deleteFunc, char *name)
>      if (!funcs)
>  	return 0;
>      if (!dixRegisterPrivateOffset(next, -1))
> +    {
> +	xfree (funcs);
>  	return 0;
> +    }

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091228/904a5472/attachment.pgp 


More information about the xorg-devel mailing list