[PATCH] configure: use backticks rather than $() for command substitution

[Peter Hutterer]

On Sun, Dec 20, 2009 at 10:10:47PM -0500, Gaetan Nadon wrote:
> Hi,
> 
> This patch to xserver configure.ac is to increase code portability to
> non POSIX system by using backticks rather than $() for command
> substitution for BUILD_DATE and BUILD_TIME. All automake scripts use
> backticks.
 
just a comment on the email - you could have used the paragraph above in the
commit message and then send the patch itself as email (git send-email, mutt
-H, etc.). generally, if you need an extra explanation in an email that's
not in the commit message the commit message isn't good enough. remember
that the extra information isn't available for anyone using git log.

If you find yourself struggling for what else to write in the email other
than "Hi", then you've provided enough information. :)
 
Cheers,
  Peter

> From e566c9b47ca1e8ca5a1c7a6b55728fabbc8f0525 Mon Sep 17 00:00:00 2001
> From: Gaetan Nadon <memsize at videotron.ca>
> Date: Sun, 20 Dec 2009 21:16:49 -0500
> Subject: [PATCH] configure: use backticks rather than $() for command substitution
> 
> This increases code portability to non POSIX systems.
> 
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
>  configure.ac |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index fe28a07..531c1c2 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2073,9 +2073,9 @@ AC_TRY_COMPILE([
>  
>  AC_DEFINE_DIR(PROJECTROOT, prefix, [Overall prefix])
>  
> -BUILD_DATE="$(date +'%Y%m%d')"
> +BUILD_DATE="`date +'%Y%m%d'`"
>  AC_SUBST([BUILD_DATE])
> -BUILD_TIME="$(date +'1%H%M%S')"
> +BUILD_TIME="`date +'1%H%M%S'`"
>  AC_SUBST([BUILD_TIME])
>  
>  DIX_CFLAGS="-DHAVE_DIX_CONFIG_H $XSERVER_CFLAGS"
> -- 
> 1.6.0.4
> 

> _______________________________________________
> xorg-devel mailing list
> xorg-devel at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-devel