[PATCH] Add __x86 to ifdefs to use vesa if building with Sun compilers

Adam Jackson ajax at nwnk.net
Fri Dec 18 13:42:09 PST 2009


On Thu, 2009-12-17 at 11:09 -0800, Alan Coopersmith wrote:
> Adam Jackson wrote:
> > On Wed, 2009-12-16 at 16:45 -0800, Alan Coopersmith wrote:
> >> Sun compilers don't include the trailing __ after __i386 and __amd64
> >> like gcc, but do provide __x86 as a shorthand for __i386 || __amd64 .
> > 
> > Ennh.  It works, but it seems like we'd be better to do:
> > 
> > #if defined(__i386) && !defined(__i386__)
> > #define __i386__ __i386
> > #endif
> > #if defined(__amd64) && !defined(__amd64__)
> > #define __amd64__ __amd64
> > #endif
> > 
> > in compiler.h in the sdk, and then use the __beforeandafter__ versions
> > consistently.
> 
> I did that at first, but then hit other build failures in the PC98 mess.
> That's probably fixable by ensuring compiler.h is consistently included
> though.   I'll try poking at that some more.   (Do we still need PC98
> support?)

I don't think we do, no.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
Url : http://lists.x.org/archives/xorg-devel/attachments/20091218/f0f86c23/attachment.pgp 


More information about the xorg-devel mailing list