[PATCH 1-12/41] joystick .. xgixp: configure.ac: use backticks rather than $() for cmd subs
Gaetan Nadon
gaetan.nadon at videotron.ca
Thu Dec 17 16:47:52 PST 2009
Hi,
There are 41 driver modules with the line:
sdkdir=$(pkg-config --variable=sdkdir xorg-server)
Following up on review
http://lists.x.org/archives/xorg-devel/2009-November/003711.html
From Dan Nicholson:
This should be
sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`
1. The user may need to use a specific pkg-config or pass custom
arguments to it. Think multiarch or cross-compiling scenarios.
2. Backticks (``) are supported by all shells while $() command
substitution is for strictly POSIX conforming shells. We don't
need to
limit ourselves to that subset.
There are 12 drivers who are effectively using this line:
joystick, synaptics, glint, intel, mach64, mga, r128, savage,
sis, tdfx, xgi, xgixp
I intend to apply this patch to all 12 of them. Other patches for the
remainder modules will follow.
The reference patch is from input-synaptics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.x.org/archives/xorg-devel/attachments/20091217/f2795c88/attachment.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-configure.ac-use-backticks-rather-than-for-cmd.patch
Type: text/x-patch
Size: 0 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091217/f2795c88/attachment.bin
More information about the xorg-devel
mailing list