[PATCH] EXA/mixed: Don't consider devKind for detecting dimension change.

Michel Dänzer michel at daenzer.net
Wed Dec 9 15:04:53 PST 2009


From: Michel Dänzer <daenzer at vmware.com>

Fixes http://bugs.freedesktop.org/show_bug.cgi?id=25536 .

There should be no reason for the pitch to actually change when none of the
other dimensions do, and this could lead to incorrectly freeing the system
memory copy when allocating a GPU copy, resulting in loss of valid pixmap
contents.

Signed-off-by: Michel Dänzer <daenzer at vmware.com>
---
 exa/exa_mixed.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/exa/exa_mixed.c b/exa/exa_mixed.c
index 0fb644b..155ed47 100644
--- a/exa/exa_mixed.c
+++ b/exa/exa_mixed.c
@@ -155,7 +155,6 @@ exaModifyPixmapHeader_mixed(PixmapPtr pPixmap, int width, int height, int depth,
 
     if (width != pPixmap->drawable.width ||
 	height != pPixmap->drawable.height ||
-	devKind != pPixmap->devKind ||
 	depth != pPixmap->drawable.depth ||
 	bitsPerPixel != pPixmap->drawable.bitsPerPixel) {
 	if (pExaPixmap->driverPriv) {
-- 
1.6.5.4



More information about the xorg-devel mailing list