[PATCH] I/O port access routines

Adam Jackson ajax at nwnk.net
Wed Dec 9 09:18:07 PST 2009


On Tue, 2009-12-08 at 20:22 +0100, Mark Kettenis wrote:

> > +struct pci_io_handle {
> > +    pciaddr_t base;
> > +    pciaddr_t size;
> > +    int fd;
> > +};
> > +
> 
> The 'fd' member here is specific to your Linux implementation.  For
> OpenBSD I'll have to add other members.  How do we want to handle
> that?
> 
> 1. Just accept that there will be members that are unused on some
>    platforms?
> 
> 2. Add #ifdef's?
> 
> 3. Move the definition of this struct into a platform-specific header file?

Platform ifdef seems like the simplest thing to me.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
Url : http://lists.x.org/archives/xorg-devel/attachments/20091209/d17dcb02/attachment.pgp 


More information about the xorg-devel mailing list