[PATCH] EXA: ModifyPixmapHeader_mixed fixes.

[Michel Dänzer]

On Sat, 2009-12-05 at 19:21 +0100, Maarten Maathuis wrote: 
> 2009/12/5 Michel Dänzer <michel at daenzer.net>:
> > On Sat, 2009-12-05 at 17:59 +0100, Maarten Maathuis wrote:
> >> 
> >> Not every driver has an MPH hook and they certainly don't return TRUE
> >> all the time. Why not remove the MPH here and just stick to deleting
> >> the sysram copy?
> >
> > I'll try that.
> >
> >> (don't forget deferred pixmaps)
> >
> > What do you suggest should be done about them here? Note that I was
> > going to propose removing deferred pixmaps again, they seem to cause
> > problems with optimized migration and the latter seems to help more.
> 
> You need to copy back deferred content to the gpu pixmap.

Yeah, maybe. ModifyPixmapHeader is such a messy interface...

> Isn't optimized migration on by default?

I thought it was and it's supposed to be, but I recently discovered it
can only be enabled with classic as of yet. I'll submit a patch to fix
that, but unless I can figure out why it breaks deferred pixmaps, only
after removing those again.


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer