[PATCH] EXA: Use correct coordinate system for calculating Composite fallback region.

Michel Dänzer michel at daenzer.net
Thu Dec 3 09:11:02 PST 2009


On Thu, 2009-12-03 at 09:07 -0800, Keith Packard wrote: 
> On Thu, 03 Dec 2009 16:59:09 +0100, Michel Dänzer <michel at daenzer.net> wrote:
> 
> > Ugh, sounds like it'll be tricky to get this 100% correct for source
> > pictures with ->pDrawable->x/y != 0...
> 
> You can't use the source clip region to compute an operation region when
> the source has a transform, that's for sure. Aside from that, adjusting
> the transform to incorporate the drawable offset is fairly trivial (I've
> posted a patch for fb which does this).
> 
> > Fortunately though, that's a relatively academic issue compared to the
> > real problem occurring with window destination pictures. As a first
> > step, would you accept a patch with only the destination coordinate
> > adjustments?
> 
> Can you take a look at my fb patch and see if you can adopt a similar
> technique for exa? It isn't very complicated.

*Sigh*. Does it really need to remain broken until there's a (believed
to be) 100% correct solution? What's wrong with fixing at least one real
problem for now?


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the xorg-devel mailing list