[PATCH 1/2] Add pci_device_get_parent_bridge()
Adam Jackson
ajax at nwnk.net
Wed Dec 2 12:51:22 PST 2009
On Thu, 2009-11-19 at 17:48 +0200, Tiago Vignatti wrote:
> On Wed, Nov 18, 2009 at 08:28:56PM +0100, ext Adam Jackson wrote:
> > +
> > +#define PCI_CLASS_BRIDGE 0x06
> > +#define PCI_SUBCLASS_BRIDGE_PCI 0x04
>
> Shouldn't we move all PCI config space definitions to some common place?
>
> For instance pcitutils already defines this particular macro as
> PCI_BASE_CLASS_BRIDGE and we could use that. Well, seems that we're slowly
> deprecating pciutils, but we should have the same header file in libpciaccess.
Icky, yeah. It makes sense for us to have a header for this stuff, but
I don't like the idea of conflicting or redundant definitions with
pciutils. Someone should think this through.
> Besides the header thing, it's:
>
> Acked-by: Tiago Vignatti <tiago.vignatti at nokia.com>
Pushed, thanks.
- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
Url : http://lists.x.org/archives/xorg-devel/attachments/20091202/bb720abb/attachment.pgp
More information about the xorg-devel
mailing list