[PATCH] dix: remove all but main() from main.c

Alan Coopersmith Alan.Coopersmith at Sun.COM
Thu Apr 23 21:23:37 PDT 2009


Peter Hutterer wrote:
> --- a/dix/dispatch.c
> +++ b/dix/dispatch.c
> +#ifndef PANORAMIX
> +static
> +#endif
> +Bool
> +CreateConnectionBlock(void)

Shouldn't the #ifndef PANORAMIX/static/#endif block go away now, since it's
always called from another file (main.c), even when not building with Xinerama?

(Would be nice if it ended up with a prototype in a .h file too, instead of
 multiple extern definitions in multiple .c files.   Shouldn't be exported to
 modules in the SDK - can probably be declared _X_HIDDEN even, since when
 Xinerama is built, it has to be builtin to the core server.)

-- 
	-Alan Coopersmith-           alan.coopersmith at sun.com
	 Sun Microsystems, Inc. - X Window System Engineering



More information about the xorg-devel mailing list