[PATCH] Fix MMX & SSE intrinsics to work with Sun compilers & Solaris

[Donnie Berkholz]

On 09:44 Sat 04 Apr     , Alan Coopersmith wrote:
> Robert Noland wrote:
> > On Sat, 2009-04-04 at 09:01 +0200, Rémi Cardona wrote:
> >> Le 04/04/2009 02:50, Alan Coopersmith a écrit :
> >>> +if test "x$MMX_CFLAGS" = "x" ; then
> >> [...]
> >>> +fi
> >>> +if test "x$SSE2_CFLAGS" = "x" ; then
> >> [...]
> >>> +fi
> >> What's the reason for checking if the variables already exist? The old 
> >> code just set them right away.
> > 
> > This method allows them to be over-ridden from the environment.
> 
> Exactly - lets a packager/builder override without having to edit configure.ac
> and regenerate the configure script, if they need different compiler flags for
> some reason.

In that case, you might want to call AC_ARG_VAR on them so they actually 
show up in --help output. They're little help if you have to read 
configure.ac to know they exist.

-- 
Thanks,
Donnie

Donnie Berkholz
X team lead, Gentoo Linux
Blog: http://dberkholz.wordpress.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20090410/69cfa3b1/attachment.pgp