[PATCH] kbproto: typedef instead of #define
Jeremy Huddleston
jeremyhu at freedesktop.org
Mon Apr 6 17:34:38 PDT 2009
On Apr 6, 2009, at 10:29, Adam Jackson wrote:
> On Sun, 2009-04-05 at 19:47 -0700, Jeremy Huddleston wrote:
>> The #define Status mucks up some Carbon headers on intel. See:
>> https://bugzilla.mozilla.org/show_bug.cgi?id=484457
>>
>> Anyone who has any reason why these should not be typedefs should
>> speak up now.
>
> While changing them to be typedef seems correct, XKBsrv.h isn't
> actually
> used in the X server anymore, and should never be used from clients in
> the first place.
You know what, you're right ... it was from Xlib.h ... so this too:
diff --git a/include/X11/Xlib.h b/include/X11/Xlib.h
index 44557ea..e134c62 100644
--- a/include/X11/Xlib.h
+++ b/include/X11/Xlib.h
@@ -107,8 +107,8 @@ _Xmblen(
typedef char *XPointer;
-#define Bool int
-#define Status int
+typedef int Bool;
+typedef int Status;
#define True 1
#define False 0
More information about the xorg-devel
mailing list