bitmap: Changes to 'master'

[GitLab Mirror]

 BitEdit.c  |    6 +--
 Bitmap.c   |   66 ++++++++++++++++++++++++---------------
 Bitmap.h   |   22 ++++++++++++-
 CutPaste.c |    5 +--
 Dialog.c   |    9 +----
 Graphics.c |  101 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 ReqMach.c  |   11 +++---
 bmtoa.c    |    7 +---
 8 files changed, 175 insertions(+), 52 deletions(-)

New commits:
commit 59386837b8484f557bc4c67b576d65593ec6ad7b
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Jul 26 13:15:36 2025 -0700

    Clear 10 of 15 -Wsign-compare warnings from gcc 15.1
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/bitmap/-/merge_requests/11>

commit f46943f5495e3c345e0ba6573e4d68ce230609f6
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Jul 26 13:00:18 2025 -0700

    StripFilename: avoid calling strrchr on NULL filename
    
    Found by gcc 15.1:
    Bitmap.c: In function ‘StripFilename’:
    Bitmap.c:674:25: warning: use of NULL ‘filename’ where non-null expected
     [CWE-476] [-Wanalyzer-null-argument]
      674 |     const char *begin = strrchr(filename, '/');
          |                         ^~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/bitmap/-/merge_requests/11>

commit 7284fd3c7a69d81fb72f496af3c44f505d8e1763
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Jul 26 12:10:18 2025 -0700

    Handle -Wcast-function-type warnings for functions used as XtActionProcs
    
    Fixes 19 warnings from gcc 15.1 of the form:
    
    Bitmap.c:125:32: warning: cast between incompatible function types
     from ‘void (*)(struct _WidgetRec *)’
     to ‘void (*)(struct _WidgetRec *, XEvent *, const char **, Cardinal *)’
       {aka ‘void (*)(struct _WidgetRec *, union _XEvent *, const char **,
        unsigned int *)’} [-Wcast-function-type]
      125 | #define __C(A,B)  {(char *)(A),(XtActionProc)(B)}
          |                                ^
    Bitmap.c:133:3: note: in expansion of macro ‘__C’
      133 |   __C("abort",              BWAbort),
          |   ^~~
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/bitmap/-/merge_requests/11>

commit e6823baf329bf67e280ca5d2a37ba7be8886bed5
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Jul 26 10:51:28 2025 -0700

    LoseSelection: second argument should be pointer, not raw value
    
    Found by gcc 15.1:
    
    CutPaste.c: In function ‘BWGrabSelection’:
    CutPaste.c:143:47: warning: cast between incompatible function types
     from ‘void (*)(struct _WidgetRec *, Atom)’
       {aka ‘void (*)(struct _WidgetRec *, long unsigned int)’}
     to ‘void (*)(struct _WidgetRec *, Atom *)’
       {aka ‘void (*)(struct _WidgetRec *, long unsigned int *)’}
     [-Wcast-function-type]
      143 |                               (XtLoseSelectionProc)LoseSelection,
          |                               ^
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/bitmap/-/merge_requests/11>